Add New VASTPlayer (v2.6.1-rc1) #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +20,8 @@ export default function completeUrl(url, params = {}) { | |||
| ['{pageUrl}', pageUrl], | |||
| ['{cachebreaker}', timestamp], | |||
| ['{guid}', guid], | |||
| ['{container}', container], | |||
| ['{placement}', placement], | |||
There was a problem hiding this comment.
Add support for some new macros.
minznerjosh
force-pushed
the
josh__add-new-vast-player
branch
from
f1aba12 to
ef519c7
Compare
…when its video ends.
minznerjosh
force-pushed
the
josh__add-new-vast-player
branch
from
ef519c7 to
ca3a14c
Compare
ScottBouloutian
added a commit
that referenced
this pull request
Mar 4, 2016
Add New VASTPlayer (v2.6.1-rc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the player to use my new
vast-playermodule.There are a lot of changed files here. I would focus on the new version of "VASTPlayer.js" (not the diff) and my changes to "ThirdPartyPlayer.js.".
Part of #317.