Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homebrew Cask for Cinny #316

Closed
wants to merge 0 commits into from
Closed

Add Homebrew Cask for Cinny #316

wants to merge 0 commits into from

Conversation

Neved4
Copy link

@Neved4 Neved4 commented Jul 25, 2024

Description

Adds a Cask formula to install Cinny using the Homebrew package manager.

Finally fixes #62

After this PR, Cinny can be installed with:

brew tap cinnyapp/cinny-desktop https://github.com/cinnyapp/cinny-desktop
brew install cinny

The Cask formula could be moved into its own separate homebrew-tap repo under the Cinny project. See #62 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Jul 25, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Neved4
Copy link
Author

Neved4 commented Jul 25, 2024

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request Jul 25, 2024
Casks/cinny.rb Outdated Show resolved Hide resolved
@Neved4 Neved4 requested a review from kfiven July 31, 2024 11:52
@Neved4
Copy link
Author

Neved4 commented Jul 31, 2024

Note that the public_repo and workflow scopes are required in the custom access token ${{secrets.TOKEN}}

Also, moving the Casks/ into a separate homebrew-tap repo within Cinny's org will make installs simpler:

brew install cinnyapp/tap/cinny

@Neved4
Copy link
Author

Neved4 commented Sep 12, 2024

@kfiven had this running in my own private tap for a while now

So far delivering the last few upgrades with no issues: Neved4/tap/cinny_v4.2.0

Let me know if further help is needed

@neila
Copy link

neila commented Jan 13, 2025

@kfiven Can this be reviewed? Would love to see a homebrew upstream too

@Neved4
Copy link
Author

Neved4 commented Jan 15, 2025

@neila Cinny is almost quite there!

Atm doesn't meet the Acceptable Formulae criteria, since it's not signed and notarized.

Currently, it can be installed through:

brew install Neved4/tap/cinny

Future work:

  • After @kfiven or @ajbura set up a repo under the org and set up the CI/CD it'll be available under:

    brew install cinnyapp/tap/cinny
  • If the signing situation is resolved in the future I'd be more than happy to submit the formula upstream, to run:

    brew install cinnyapp/tap/cinny

Cheers!

@Neved4 Neved4 closed this Jan 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release macOS arm build of cinny-desktop + hombrew cask
3 participants