Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in fixes from mreeve quality of life fixes branch #555

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

mreeve-snl
Copy link
Collaborator

🗣 Description

Hotfix branch to fix installation issues users are running into

💭 Motivation and context

Fixes a few problems:

  1. containers take a really long time to start, and this is causing user's to see the project as failing to start
  2. issues with post-install script... some users are finding issues where the post install script fails, this branch should fix those issues and make it more robust
  3. added longer timeouts to all containers to make sure they're able to come up properly, so users don't run into issues with installation

🧪 Testing

Ran through installation manually on multiple ubuntu 22.04 machines.

✅ Pre-approval checklist

  • Changes are limited to a single goal AND
    the title reflects this in a clear human readable format
  • Issue that this PR solves has been selected in the Development section
  • I have read and agree to LME's CONTRIBUTING.md document.
  • The PR adheres to LME's requirements in RELEASES.md
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • All tests pass
  • PR has been tested and the documentation for testing is above
  • Squash and merge all commits into one PR level commit

✅ Post-merge Checklist

  • Delete the branch to keep down number of branches

@mitchelbaker-cisa mitchelbaker-cisa merged commit e11d045 into main Jan 30, 2025
5 checks passed
mitchelbaker-cisa added a commit that referenced this pull request Feb 7, 2025
* adding in fixes from mreeve quality of life fixes branch (#555)

* adding in fixes from mreeve quality of life fixes branch

* Fix issue with no directory created

* Fix issue with improper executable for shell being used

* Remove diff from troubleshooting.md

---------

Co-authored-by: Michael Reeves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants