Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malcolm v23.12.0 #290

Merged
merged 84 commits into from
Dec 5, 2023
Merged

Malcolm v23.12.0 #290

merged 84 commits into from
Dec 5, 2023

Conversation

mmguero
Copy link
Collaborator

@mmguero mmguero commented Dec 4, 2023

Malcolm v23.12.0 is a feature release with many improvements, updates and fixes

v23.10.0...v23.12.0

…olab#259); work in progress, almost certainly broken in this state
…olab#259); restore caching for performance reasons, but decrease TTL significantly and allow it to be specified via environment variable
…rsing multipart/form-data containing a large part with CR/LF character at the beginning'
* replace master/slave with client/server for modbus (idaholab#291)
* modbus updates for icsnpp-modbus (idaholab#289)
* point some Zeek plugins back upstream
* added new visualizations to modbus dashboard
@mmguero mmguero self-assigned this Dec 4, 2023
with open(loadFileName, 'w') as outfile:
for line in infile:
outfile.write(line.replace("NETBOX_DEFAULT_SITE", defaultSiteName))
except Exception:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
for x in list(filter(os.path.isfile, glob.glob(os.path.join(args.preloadDir, '*.gz'))))
if not x.endswith('.media.tar.gz')
]
preloadFiles.sort(key=lambda x: os.path.getmtime(x))

Check notice

Code scanning / CodeQL

Unnecessary lambda Note

This 'lambda' is just a simple wrapper around a callable object. Use that object directly.
import os
import psycopg

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'psycopg' is not used.
import pynetbox
import randomcolor
import re
import shutil

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'shutil' is not used.
@mmguero mmguero merged commit c097f1c into main Dec 5, 2023
4 checks passed
@mmguero mmguero deleted the v23.12.0_merge_cisagov branch December 5, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant