Support new COOL environment structure #83
+49
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids hardcoding the bucket name and allows the bucket name to be set on a per-environment basis via the -backend-config command line option or other methods. For details, see: https://developer.hashicorp.com/terraform/language/backend#partial-configuration
This will be used to avoid hard-coding the bucket name in remote_states.tf.
Also, make each remote state use the same workspace name as the current Terraform workspace.
This is our chosen extension for Terraform backend config files.
…ing schemes While I was here, I also: * Deleted local variables related to the now-defunct Domain Manager and PCA accounts * Ensured that we are only searching non-master accounts when looking for the various account IDs
…to now-defunct Domain Manager and PCA accounts
dav3r
added
the
improvement
jsf9k
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR makes updates in support of the switchover from our legacy account/environment scheme (where staging and production accounts exist within the same AWS organization) to our new scheme (where they do not).
Highlights include:
This PR also removes references to the Domain Manager and PCA accounts, which were previously removed, but never cleaned up in this repository.
💭 Motivation and context
The goal of this PR is to get us closer to our modernized account scheme where there is no more co-mingling of staging and production accounts. Doing that will result in cleaner code across all COOL-related repositories as well as improved separation of resources across all COOL environments.
🧪 Testing
I applied this code in a development environment (which uses the new account naming scheme) and confirmed that it applied successfully and appeared correct.
I also ran
terraform planin Production (which uses the legacy account naming scheme) and confirmed that all planned changes looked accurate and expected.✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Post-merge checklist