meson.build: implement mbedtls support #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iameli I have no problem with merging these changes, although I do not know much about meson build. Since we moved to github actions for CI meson builds are no longer run regularly. Would you be interested in adding a git hub action for this ? |
pabuhler
approved these changes
Dec 5, 2023
|
@pabuhler Done! Added a test that mirrors the CMake test — you can see it running successfully for a3c1688 over on my fork here https://github.com/iameli/srtp-ci-test/actions/runs/7108414189 |
|
@iameli awesome, I have merged this now. In general I dont think we will block merging changes when a meson build fails, but at least we will now know something needs to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pretty easy; just porting over mbedtls support that was already added from #512. Now it works with Meson too!