Fix frame-decode errors. #3721
Closed
Fix frame-decode errors. #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CWelsDecoder::ReorderPicturesInDisplay(), iLastWrittenPOC was not set in unbuffered-reordering case. Due to this problem, it sometimes reordered the frames incorrectly. This patch fixes the issue.
When bNewSeqBegin got true, iRefCount was forcibly reset even if the buffer was still used for reordering. Due to this problem, the buffer in use was sometimes overwritten with newly decoded frame. This commit is for fixing that problem.
Previously, when more than 2 frame sequences exist in the reordering buffer, the reordering does not work correctly. This is because the management based on bLastGOP flag does not work in this case. Instead, this patch introduces frame sequence number (iSeqNum) to distingish frames belonging to each sequence and drops bLastGOP flag.
... and fix trivial issue of that function. This solves the some frame decode error.
|
Does this PR need rebasing? |
Seems to be a Merge in there somehow, not sure how it got there. But you can checkout a clean master and cherrypick the two patches and push --force to this branch again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for both #3710 and #3713.
I am not very sure that these are the correct fixes even though the frame decode errors are indeed resolved, so please review them. Especially for #3713.