Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename hochschule-bonn-rhein-sieg.csl to hochschule-bonn-r… #7242

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Oct 7, 2024

…hein-sieg-harvard.csl

  1. I had a look at the old guidelines via archive.org and they were actually for the economics faculty. Hence I added that to the style name.
  2. As the style also describes a footnote variant I have also added "harvard" to the file name, so we don't need to change that in the future.

Guidelines (sent to me via email):
Leitfaden fuer die Gestaltung schriftlicher Arbeiten .pdf

Copy link

github-actions bot commented Oct 7, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

4 tests failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

hochschule-bonn-rhein-sieg-harvard: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

hochschule-bonn-rhein-sieg-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

hochschule-bonn-rhein-sieg-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

3 tests failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

hochschule-bonn-rhein-sieg-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

hochschule-bonn-rhein-sieg-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

3 tests failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

Please check the test report for details.

…n-harvard.csl to hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard.csl
Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

@POBrien333
Copy link
Contributor Author

Not sure where it's getting the "freie-hochschule-stuttgart" from?!

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

Copy link

github-actions bot commented Oct 9, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

@bwiernik
Copy link
Member

bwiernik commented Oct 9, 2024

Thanks! Can you add a documentation link to the pdf on this thread and
fix the template for the style that referred to the old name?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 9, 2024
@POBrien333
Copy link
Contributor Author

Thanks. I've added the documentation link.
However, the test shows and error that actually is not true. The template is our DGP style which certainly exists. Somehow it's mentioning another style.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

@adam3smith
Copy link
Member

The test fails because another style uses this one as a template and you're changing the ID. We generally prefer not changing style IDs if at all possible and I think should avoid that here.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 9, 2024
@POBrien333
Copy link
Contributor Author

Ah, that's why. Thanks.
In this case, I think at least the name should include the faculty as it can be misleading students. The style is not generic for the whole university AFAIK. Do you want to leave the ID/self-link like before then?

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 10, 2024
@adam3smith
Copy link
Member

Yes exactly -- change title but not id. I think the CI won't complain, but if it does, there's as n override

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 10, 2024
…issenschaften-harvard.csl to hochschule-bonn-rhein-sieg.csl
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

hochschule-bonn-rhein-sieg.csl (modified style)
(Hancké et al. (Hrsg.) 2007; O. V. 2012)
(Fenner et al. 2019; Mares 2001)

Fenner, Martin/Crosas, Mercè/Grethe, Jeffrey S./Kennedy, David/Hermjakob, Henning/Rocca-Serra, Phillippe et al. (2019):
A data citation roadmap for scholarly data repositories. In: Scientific Data, 2019, 6 (1), S. 28.
Hancké, Bob/Rhodes, Martin/Thatcher, Mark (Hrsg.) (2007):
Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy, Oxford and New York.
Mares, Isabela (2001):
Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall, Peter A./Soskice, David (Hrsg.), Varieties of capitalism. The institutional foundations of comparative advantage, New York, S. 184–213.
O. V. (2012):
CSL search by example [2012], http://editor.citationstyles.org/searchByExample/ [15.12.2012].
-(„CSL search by example“, 2012; Hancké et al., 2007)<br/>
-(Fenner et al., 2019; Mares, 2001)<br/>
+(Hancké et al. (Hrsg.) 2007; O. V. 2012)<br/>
+(Fenner et al. 2019; Mares 2001)<br/>
 <hr/>
-CSL search by example. (2012). <i>Citation Style Editor</i>. Zugriff am 15.12.2012. Verfügbar unter: http://editor.citationstyles.org/searchByExample/<br/>
-Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P. et al. (2019). A data citation roadmap for scholarly data repositories. <i>Scientific Data</i>, <i>6</i> (1), 28. doi:10.1038/s41597-019-0031-8<br/>
-Hancké, B., Rhodes, M. &amp; Thatcher, M. (Hrsg.). (2007). <i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>. Oxford and New York: Oxford University Press.<br/>
-Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P.A. Hall &amp; D. Soskice (Hrsg.), <i>Varieties of capitalism. The institutional foundations of comparative advantage</i> (S. 184–213). New York: Oxford University Press.<br/>
+<div class="csl-block"><b>Fenner, Martin/Crosas, Mercè/Grethe, Jeffrey S./Kennedy, David/Hermjakob, Henning/Rocca-Serra, Phillippe et al. (2019)</b>:</div>A data citation roadmap for scholarly data repositories. In: Scientific Data, 2019, <span style="font-style: normal">6</span> (1), S. 28.<br/>
+<div class="csl-block"><b>Hancké, Bob/Rhodes, Martin/Thatcher, Mark (Hrsg.) (2007)</b>:</div><i>Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy</i>, Oxford and New York.<br/>
+<div class="csl-block"><b>Mares, Isabela (2001)</b>:</div>Firms and the welfare state: When, why, and how does social policy matter to employers? In: Hall, Peter A./Soskice, David (Hrsg.), <span style="font-style: normal">Varieties of capitalism. The institutional foundations of comparative advantage</span>, New York, S. 184–213.<br/>
+<div class="csl-block"><b>O. V. (2012)</b>:</div>CSL search by example [2012], http://editor.citationstyles.org/searchByExample/ [15.12.2012].<br/>

@adam3smith adam3smith merged commit 6b62170 into citation-style-language:master Oct 10, 2024
1 check passed
@adam3smith
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants