clean up

pyjtt/app.py

@@ -89,9 +89,7 @@ def app_quit():
             utils.write_config(config)
         else:
             app_quit()
-    #TODO: add check that login and password from config are correct
-
-    main_window = gui.MainWindow(jira_host, login, password)
+    gui.MainWindow(jira_host, login, password)
     app_quit()
 
 

pyjtt/gui.py

@@ -247,7 +247,6 @@ def closeEvent(self, event):
         if confirmation == QtWidgets.QMessageBox.Yes:
             for thread in self.worker_threads:
                 thread.quit()
-            # TODO: Add checking of online tracking
             super(MainWindow, self).closeEvent(event)
         else:
             event.ignore()
@@ -311,8 +310,6 @@ def get_issue(self):
             if utils.check_jira_issue_key(issue_key):
                 get_issue_task = partial(self.app.get_issue, issue_key)
                 self.tasks_queue.put(get_issue_task)
-        #TODO: think about it.
-        #self.ui.lineIssueKey.clear()
 
     def add_worklog_entry(self):
         issue = self._get_selected_issue_from_table()

pyjtt/utils.py

@@ -32,6 +32,7 @@
 
 CONFIG_FILENAME = 'pyjtt.cfg'
 
+
 def get_app_working_dir():
     """Returns path to application operational folder.
 
@@ -71,12 +72,18 @@ def write_config(config):
     with open(os.path.join(workdir, CONFIG_FILENAME), 'w') as configfile:
             config.write(configfile)
 
+
 def get_local_utc_offset(now, utcnow):
     """Calculates local UTC offset. Returns string"""
     logger.debug('Getting local UTC Offset')
 
     def absolute_offset(bigger_timestamp, smaller_timestamp):
         minutes = bigger_timestamp.minute - smaller_timestamp.minute
+        # Case when, minutes can be differ on one minute because
+        # of time gap between now and utcnow. This difference cannot
+        # be more than one minute
+        if minutes == 1:
+            minutes = 0
         hours_diff = abs(bigger_timestamp.hour - smaller_timestamp.hour)
         if minutes < 0:
             hours_diff -= 1
@@ -102,7 +109,6 @@ def get_timedelta_from_utc_offset(time_string):
     utc_offset = time_string[-5:]
     hours = int(utc_offset[0:3])
     minutes = int(utc_offset[3:5])
-    # TODO: add bound values checking
     return timedelta(hours=hours, minutes=minutes)
 
 

tests/utils_tests.py

@@ -47,10 +47,9 @@ def test_get_local_utc_offset_simple(self):
         utcnow = datetime.datetime(2013, 1, 4, 16, 35)
         self.assertEqual(utils.get_local_utc_offset(now, utcnow), '-0530')
         # Different minutes MSK
-        # TODO: Fix this
-        #now = datetime.datetime(2013, 1, 4, 11, 5)
-        #utcnow = datetime.datetime(2013, 1, 4, 7, 4)
-        #self.assertEqual(utils.get_local_utc_offset(now, utcnow), '+0400')
+        now = datetime.datetime(2013, 1, 4, 11, 5)
+        utcnow = datetime.datetime(2013, 1, 4, 7, 4, 59)
+        self.assertEqual(utils.get_local_utc_offset(now, utcnow), '+0400')
 
     def test_get_local_utc_offset_errors(self):
         # wrong year