Skip to content

Commit

Permalink
Merge disable netgameeventv2 default (mr-557)
Browse files Browse the repository at this point in the history
4d8d2f6 - tweak(server): disable netgameeventv2 default
  • Loading branch information
nihonium-cfx committed Oct 16, 2024
2 parents 20656b6 + 4d8d2f6 commit 60f7711
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ static InitFunction initFunction([]()
auto experimentalStateBagsHandler = instance->AddVariable<bool>("sv_experimentalStateBagsHandler", ConVar_None, true);
auto experimentalOneSyncPopulation = instance->AddVariable<bool>("sv_experimentalOneSyncPopulation", ConVar_None, true);
// todo: remove fx::ServerGameState::GetGameEventHandler, fx::ServerGameState::GetHandler and fx::ServerGameState::GetRequestControlEventHandler when experimentalNetEvents is enabled by default and no longer a experiment
auto experimentalNetEvents = instance->AddVariable<bool>("sv_experimentalNetGameEventHandler", ConVar_None, true);
auto experimentalNetEvents = instance->AddVariable<bool>("sv_experimentalNetGameEventHandler", ConVar_None, false);

instance->GetComponent<fx::ClientMethodRegistry>()->AddHandler("initConnect", [=](const std::map<std::string, std::string>& postMap, const fwRefContainer<net::HttpRequest>& request, const std::function<void(const json&)>& cb)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7638,7 +7638,7 @@ static InitFunction initFunction([]()
g_oneSyncLengthHack = instance->AddVariable<bool>("onesync_enableBeyond", ConVar_ReadOnly, false);

g_experimentalOneSyncPopulation = instance->AddVariable<bool>("sv_experimentalOneSyncPopulation", ConVar_None, true);
g_experimentalNetGameEventHandler = instance->AddVariable<bool>("sv_experimentalNetGameEventHandler", ConVar_None, true);
g_experimentalNetGameEventHandler = instance->AddVariable<bool>("sv_experimentalNetGameEventHandler", ConVar_None, false);

constexpr bool canLengthHack =
#ifdef STATE_RDR3
Expand Down

2 comments on commit 60f7711

@Legacy-TacticalGamingInteractive

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we now remove sv_experimentalNetGameEventHandler false from server.cfg?
(was testing this just to see if it helped with netgameevent errors lately)

@DaniGP17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only will affect for future server artifacts, you can steel have the sv_experimentalNetGameEventHandler set to false

Please sign in to comment.