fix(voip/mumble): Voice cracking on high load #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
RedM
Nobelium-cfx
approved these changes
Sep 9, 2024
prikolium-cfx
added
ready-to-merge
dmex
reviewed
Sep 20, 2024
| @@ -1469,6 +1469,8 @@ void MumbleAudioOutput::ThreadFunc() | |||
|
|
|||
| mmcssHandle = AvSetMmThreadCharacteristics(L"Audio", &mmcssTaskIndex); | |||
|
|
|||
| SetThreadPriority(GetCurrentThread(), THREAD_PRIORITY_ABOVE_NORMAL); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -96,6 +96,8 @@ void MumbleAudioInput::ThreadFunc() | |||
| { | |||
| SetThreadName(-1, "[Mumble] Audio Input Thread"); | |||
|
|
|||
| SetThreadPriority(GetCurrentThread(), THREAD_PRIORITY_ABOVE_NORMAL); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
i have this cracking issue only in "voice_useNativeAudio" mumble mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix voice cracking on high load
How is this PR achieving the goal
Setting a higher thread priority for Mumble voice. These changes need to be tested on Canary; I can't see any other way to conduct large-scale tests. I tried to create this issue using two RedM clients and running a CPU stress test in the background, but there was no way to replicate this on my PC and my friend's PC.
This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds: 1491
Platforms: Windows
Checklist
Fixes issues
fixes #2742