Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native/getbuild): new native to get the version of FXServer #2865

Closed
wants to merge 1 commit into from

Conversation

spacevx
Copy link
Contributor

@spacevx spacevx commented Oct 15, 2024

Goal of this PR

Introduce a native to get the build number of FXServer

How is this PR achieving the goal

By creating a class BuildInfo in the file BuildInfo.cpp who is a getter to get the version of FXServer (the code was taken from the server command "version")

This PR applies to the following area(s)

FXServer

Successfully tested on

Couldn't be tested since we can't get the version of FXServer when building it

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Oct 15, 2024
@pachxl
Copy link

pachxl commented Oct 15, 2024

GetConvarInt("buildVersion") is all you need

@spacevx
Copy link
Contributor Author

spacevx commented Oct 15, 2024

GetConvarInt("buildVersion") is all you need

Are you sure this convar exist?

@Korioz
Copy link
Contributor

Korioz commented Oct 15, 2024

He probably means buildNumber

@spacevx
Copy link
Contributor Author

spacevx commented Oct 15, 2024

He probably means buildNumber

Good to know then. I'm going to close the PR!

@spacevx spacevx closed this Oct 15, 2024
@outsider31000
Copy link
Contributor

if its not on the docs maybe its should be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants