Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(ext/cfx-ui): Hide rateLimiter_* ConVar's #2874

Closed
wants to merge 1 commit into from

Conversation

Yum1x
Copy link

@Yum1x Yum1x commented Oct 22, 2024

Inspired by (#2867) this hides all rateLimiter related ConVar's in the server info view

Goal of this PR

Showing this information to the end-user isn't really helpful, so we hide it.
image

How is this PR achieving the goal

Adding an exception for "rateLimiter_*" in the server info aggregation function.

This PR applies to the following area(s)

cfx-ui

Successfully tested on

Game builds: Not applicable

Platforms: Windows (Client)

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

.

This hides all *rateLimiter* related ConVar's in the server info view
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Oct 22, 2024
@AvarianKnight
Copy link
Contributor

This shouldn't be shown unless you're specifically setting it via sets

@AvarianKnight
Copy link
Contributor

Use set instead of sets if you don't want it to be included in the vars list.

@Yum1x
Copy link
Author

Yum1x commented Oct 22, 2024

misreading the previous comment, closing due to unnecessary and wrong conception.

@Yum1x Yum1x closed this Oct 22, 2024
@Yum1x Yum1x deleted the patch-1 branch October 22, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants