Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(font-renderer): force watermark bottom right #3033

Closed
wants to merge 2 commits into from

Conversation

alberttheprince
Copy link

@alberttheprince alberttheprince commented Dec 23, 2024

Goal of this PR

Watermark currently randomly moves between the top right and bottom right of the player's screen, which is unnecessary. A set position (bottom right was chosen, as it's just a standard/out-of-the-way spot common across the industry) would allow more reliable expectations for the UI.

How is this PR achieving the goal

Position is hardcoded to bottom right, rather than top and bottom right randomly.

This PR applies to the following area(s)

FiveM client

Successfully tested on

Game builds: 3258

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Quality of life update, frees up the top right of the screen and sets a position for the watermark going forward.

Watermark currently randomly moves between the top right and bottom right of the player's screen, which is unnecessary. A set position (bottom right is common across the industry) would allow more reliable expectations for the UI.
Watermark currently randomly moves between the top right and bottom right of the player's screen, which is unnecessary. A set position (bottom right is common across the industry) would allow more reliable expectations for the UI.
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Dec 23, 2024
@alberttheprince alberttheprince changed the title Force Version/watermark to bottom right tweak: Force Version/watermark to bottom right Dec 23, 2024
@alberttheprince alberttheprince changed the title tweak: Force Version/watermark to bottom right tweak(font-renderer): force watermark bottom right Dec 23, 2024
@alberttheprince
Copy link
Author

Reopening with correct format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant