fix(commerce): allow the server to refresh sku's after initial load #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If users were to buy a new package while already in game this would still return that they didn't own the specified sku and it would stay like this until they rejoined, this isn't good user experience so instead we allow the server to refresh the skus once every 10 seconds
github-actions
bot
added
triage
FabianTerhorst
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was talking with @The-Neco about the usage of some of the commerce natives but found that their usage was extremely limited because they could not be updated after the first request.
Goal of this PR
Allow LoadPlayerCommerceDataExt to reload player SKUs while in game, this currently only fetched once and cannot be updated until the player rejoins, this adds unnecessary friction.
This allows
LoadPlayerCommerceDataExtto fetch the players packages again once every 10 seconds.How is this PR achieving the goal
Calls to
LoadPlayerCommerceDataExtafter 10 seconds will refresh the clients SKUsThis PR applies to the following area(s)
Server
Successfully tested on
Platforms: Windows
Checklist