Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(game/five): add ped prop collection natives #3060

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

william-des
Copy link
Contributor

Goal of this PR

Add two new FiveM client natives for prop collections to provide parity with existing drawable variation natives. The new natives allow retrieving collection-local indices and collection names for ped props, similar to GetPedDrawableVariationCollectionLocalIndex and GetPedDrawableVariationCollectionName.

How is this PR achieving the goal

Added two new native functions

  1. GET_PED_PROP_COLLECTION_LOCAL_INDEX: Returns the collection-local index for a prop at a given anchor point
  2. GET_PED_PROP_COLLECTION_NAME: Returns the collection name for a prop at a given anchor point

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 3095

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Jan 10, 2025
Copy link
Contributor

@Nobelium-cfx Nobelium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Looks great overall.

Left some minor comments. We can merge it after they are resolved.

@william-des william-des force-pushed the prop-collection-natives branch from 77c9445 to eb9d838 Compare January 10, 2025 11:52
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Jan 10, 2025
Copy link
Contributor

@Nobelium-cfx Nobelium-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Nobelium-cfx Nobelium-cfx added the ready-to-merge This PR is enqueued for merging label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants