Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extra-natives/five): REGISTER_ROPE_DATA #3062

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

packfile
Copy link
Contributor

Goal of this PR

Adds a way to register custom rope data during gameplay and fixes a crash if an invalid rope type is passed into ADD_ROPE

This superceeds an earlier PR #2205 which wasn't friendly if multiple resources wanted to have custom rope data

How is this PR achieving the goal

Adds REGISTER_ROPE_DATA which has parameters matching the fields seen in ropedata.xml, allowing you to create ropes with different sizes, textures, etc

Clamps the ropeType of ADD_ROPE so that a crash will not occur if an invalid type is passed

This PR applies to the following area(s)

FiveM, Natives

Successfully tested on

Game builds: 1604, 2060, 2189, 2372, 2545, 2612, 2699, 2802, 3095, 3258, 3323, 3407

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant