redo

src/backend/distributed/sql/udfs/create_time_partitions/latest.sql

@@ -32,18 +32,14 @@ BEGIN
         SELECT *
         FROM get_missing_time_partition_ranges(table_name, partition_interval, end_at, start_from)
     LOOP
-        EXECUTE format('CREATE TABLE %I.%I (LIKE %I INCLUDING DEFAULTS INCLUDING CONSTRAINTS)',
+        EXECUTE format('CREATE TABLE %I.%I PARTITION OF %I.%I FOR VALUES FROM (%L) TO (%L)',
         schema_name_text,
         missing_partition_record.partition_name,
-        table_name_text);
-        EXECUTE format('ALTER TABLE %I.%I ATTACH PARTITION %I.%I FOR VALUES FROM (%L) TO (%L)',
         schema_name_text,
         table_name_text,
-        schema_name_text,
-        missing_partition_record.partition_name,
         missing_partition_record.range_from_value,
         missing_partition_record.range_to_value);
-        RAISE NOTICE 'created partition % for table %', missing_partition_record.partition_name, table_name_text;
+
         partition_created := true;
     END LOOP;
 
@@ -55,4 +51,4 @@ COMMENT ON FUNCTION pg_catalog.create_time_partitions(
     partition_interval INTERVAL,
     end_at timestamptz,
     start_from timestamptz)
-IS 'create time partitions for the given range';
+IS 'create time partitions for the given range';

src/backend/distributed/sql/udfs/drop_old_time_partitions/latest.sql

@@ -57,13 +57,12 @@ BEGIN
         ORDER BY to_value%1$s::timestamptz', custom_cast);
     FOR r IN EXECUTE older_partitions_query USING table_name, older_than
     LOOP
-        RAISE NOTICE 'dropping % with start time % and end time % using DETACH PARTITION partition_name AND THEN DROP IT. ', r.partition, r.from_value, r.to_value;
-        EXECUTE format('ALTER TABLE %I.%I DETACH PARTITION %I',r.schema_name, r.table_name, r.partition);
+        RAISE NOTICE 'dropping % with start time % and end time %', r.partition, r.from_value, r.to_value;
         EXECUTE format('DROP TABLE %I.%I', r.schema_name, r.table_name);
     END LOOP;
 END;
 $$;
 COMMENT ON PROCEDURE pg_catalog.drop_old_time_partitions(
     table_name regclass,
     older_than timestamptz)
-IS 'drop old partitions of a time-partitioned table';
+IS 'drop old partitions of a time-partitioned table';