Adds make clean to installation steps #7052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you make a fresh install make clean is not required. However, if you install before, without a make install, one can get errors
Codecov Report
@@ Coverage Diff @@
## main #7052 +/- ##
==========================================
+ Coverage 93.21% 93.36% +0.14%
==========================================
Files 275 273 -2
Lines 59456 58527 -929
==========================================
- Hits 55421 54641 -780
+ Misses 4035 3886 -149 |
Should we say "without a make clean" instead of "without a make install" in PR comment? And You can remove "DESCRIPTION" line since we use it to track user facing PRs in changelog. |
aykut-bozkurt
approved these changes
Jul 12, 2023
Co-authored-by: aykut-bozkurt <[email protected]>
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
If you make a fresh install make clean is not required. However, if you install before, without a make install, one can get errors --------- Co-authored-by: aykut-bozkurt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you make a fresh install make clean is not
required. However, if you install before, without
a make install, one can get errors