Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG16 - Propagate statistics without a user-specified name #7127

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naisila
Copy link
Member

@naisila naisila commented Aug 17, 2023

Relevant PG commit:
postgres/postgres@624aa2a

Check only last commit for now, until we merge PG16 support for regression tests.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #7127 (64c7c90) into main (682dca1) will decrease coverage by 0.02%.
The diff coverage is 95.55%.

❗ Current head 64c7c90 differs from pull request most recent head e619127. Consider uploading reports for the commit e619127 to get more accurate results

@@            Coverage Diff             @@
##             main    #7127      +/-   ##
==========================================
- Coverage   93.40%   93.38%   -0.02%     
==========================================
  Files         273      273              
  Lines       58956    58995      +39     
==========================================
+ Hits        55068    55093      +25     
- Misses       3888     3902      +14     

@naisila naisila force-pushed the naisila/pg16_statistics branch 2 times, most recently from e7c747b to 64c7c90 Compare August 17, 2023 13:20
@onderkalaci
Copy link
Member

Just noting our internal discussion here: Giving auto-names is a tricky task, especially with sharding + partitioning involved. The reason is that there might be name collusions, and those are non-trivial to spot.

Although the proposed code changes might work as-is, we decided to deprioritize this patch for now, and focus on robustness over new PG16 features. We might come back to this once we resolve all the other PG16 integration issues.

@naisila maybe we should mark this as a draft for now?

@naisila naisila marked this pull request as draft September 4, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants