PG16 - Add COPY FROM default tests #7143
Conversation
naisila
force-pushed
the
naisila/pg16_copy_from_default
branch
from
c5f29e1
to
cf5b9d7
Compare
Codecov Report
@@ Coverage Diff @@
## main #7143 +/- ##
==========================================
- Coverage 93.41% 93.32% -0.10%
==========================================
Files 272 272
Lines 58990 58988 -2
==========================================
- Hits 55108 55048 -60
- Misses 3882 3940 +58 |
| -- COPY FROM ... DEFAULT | ||
| -- Already supported in Citus, adding all PG tests with a distributed table | ||
| -- Relevant PG commit: | ||
| -- https://github.com/postgres/postgres/commit/9f8377f |
There was a problem hiding this comment.
Copy on the shards that are local goes through a different codepath. So, I think it'd be very useful to add one very basic test to make sure it works.
A good alternative could be to create a citus-local (or a reference table), where the shard will be local to the coodinator.
Or, connect to one of the workers and ensure the copy is happening at least one local shard.
There was a problem hiding this comment.
Or, connect to one of the workers and ensure the copy is happening at least one local shard.
Thanks, I picked this one.
naisila
force-pushed
the
naisila/pg16_copy_from_default
branch
2 times, most recently
from
0214e91
to
a94a63a
Compare
| \c - - - :master_port | ||
| TRUNCATE pg16.copy_default; | ||
| \c - - - :worker_2_port | ||
| COPY pg16.copy_default FROM stdin WITH (format csv, default '\D'); |
There was a problem hiding this comment.
as we sure that there are local shards here? if not, please consider adjusting the "id".
I'd be even fine to set citus.log_local_commands TO ON;
There was a problem hiding this comment.
We are sure one of the two workers has shards, so I just connected to both of them.
Relevant PG commit: postgres/postgres@9f8377f Already supported in Citus, adding the same tests as in PG
naisila
force-pushed
the
naisila/pg16_copy_from_default
branch
from
a94a63a
to
c7dae63
Compare
Already supported in Citus, adding the same tests as in PG Relevant PG commit: postgres/postgres@9f8377f
Already supported in Citus, adding the same tests as in PG
Relevant PG commit:
postgres/postgres@9f8377f
#7138