PG16 - Add tests for createdb with ICU_RULES option #7161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Codecov Report
@@ Coverage Diff @@
## main #7161 +/- ##
==========================================
- Coverage 93.21% 93.05% -0.16%
==========================================
Files 274 274
Lines 59235 59234 -1
==========================================
- Hits 55213 55120 -93
- Misses 4022 4114 +92 |
naisila
force-pushed
the
naisila/pg16_createdb
branch
from
01d84c3
to
1054046
Compare
onderkalaci
approved these changes
Sep 4, 2023
| CREATE EXTENSION citus; | ||
| \c - - - :worker_2_port | ||
| CREATE EXTENSION citus; | ||
| \c - - - :master_port |
There was a problem hiding this comment.
let's use citus_add_node as we might get rid of the master_ ones at some poing
naisila
force-pushed
the
naisila/pg16_createdb
branch
from
1054046
to
03fd520
Compare
When we create a database, it already needs to be manually created in the workers as well. This new icu_rules option should work as the other options as well. Added a test for that. Relevant PG commit: postgres/postgres@30a53b7
naisila
force-pushed
the
naisila/pg16_createdb
branch
from
03fd520
to
63338de
Compare
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
When we create a database, it already needs to be manually created in the workers as well. This new icu_rules option should work as the other options as well. Added a test for that. Relevant PG commit: postgres/postgres@30a53b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a database, it already needs to be manually created in the workers as well.
This new icu_rules option should work as the other options as well. Added a test for that.
Relevant PG commit:
postgres/postgres@30a53b7
#7138