PG16 - Add rules option to CREATE COLLATION #7185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
naisila
changed the title
Codecov Report
@@ Coverage Diff @@
## main #7185 +/- ##
==========================================
- Coverage 93.19% 93.18% -0.02%
==========================================
Files 274 274
Lines 59322 59327 +5
==========================================
- Hits 55288 55285 -3
- Misses 4034 4042 +8 |
onderkalaci
reviewed
Sep 6, 2023
| { | ||
| collicurules = TextDatumGetCString(datum); | ||
| appendStringInfo(&collationNameDef, ", rules = %s", | ||
| quote_literal_cstr(collicurules)); |
There was a problem hiding this comment.
the only thing that I'm not very sure is quote_literal_cstr. Is our test dealing with a rule that have escape chars?
There was a problem hiding this comment.
I couldn't quite understand your question - do we need another quote function here?
collicurules should be quoted as part of the sql syntax.
naisila
force-pushed
the
naisila/pg16_collation_rules
branch
from
a32f744
to
74971ad
Compare
onderkalaci
approved these changes
Sep 7, 2023
Relevant PG commit: postgres/postgres@30a53b7 30a53b7
naisila
force-pushed
the
naisila/pg16_collation_rules
branch
from
74971ad
to
d55f583
Compare
francisjodi
pushed a commit
that referenced
this pull request
Nov 13, 2023
Relevant PG commit: postgres/postgres@30a53b7 30a53b7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant PG commit:
postgres/postgres@30a53b7
30a53b7
#7138