Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong PR links in changelog #7350

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix wrong PR links in changelog #7350

merged 1 commit into from
Nov 16, 2023

Conversation

hanefi
Copy link
Member

@hanefi hanefi commented Nov 16, 2023

When preparing changelog for 12.1.1 release, I accidentally swapped the PR numbers for the two commits. This commit fixes the changelog to point to the correct PRs.

When preparing changelog for 12.1.1 release, I accidentally swapped
the PR numbers for the two commits. This commit fixes the changelog
to point to the correct PRs.
@hanefi hanefi requested a review from thanodnl November 16, 2023 10:46
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #7350 (c549bc7) into main (0d1f188) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7350      +/-   ##
==========================================
- Coverage   89.58%   89.58%   -0.01%     
==========================================
  Files         277      277              
  Lines       59690    59690              
  Branches     7438     7438              
==========================================
- Hits        53475    53472       -3     
- Misses       4082     4084       +2     
- Partials     2133     2134       +1     

Copy link
Member

@thanodnl thanodnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanefi hanefi merged commit 5efd3f1 into main Nov 16, 2023
126 checks passed
@hanefi hanefi deleted the fix-changelog branch November 16, 2023 11:12
hanefi added a commit that referenced this pull request Nov 16, 2023
When preparing changelog for 12.1.1 release, I accidentally swapped
the PR numbers for the two commits. This commit fixes the changelog
to point to the correct PRs.

(cherry picked from commit 5efd3f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants