Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the limit is null #7665

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Check if the limit is null #7665

merged 4 commits into from
Jul 31, 2024

Conversation

eaydingol
Copy link
Contributor

DESCRIPTION: Add a check to see if the given limit is null.

Fixes a bug by checking if the limit given in the query is null when the actual limit is computed with respect to the given offset.
Prior to this change, null is interpreted as 0 during the limit calculation when both limit and offset are given.

Fixes #7663

@eaydingol eaydingol requested a review from mtuncer July 30, 2024 08:57
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (2a263fe) to head (257c2c8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7665      +/-   ##
==========================================
- Coverage   89.70%   89.68%   -0.02%     
==========================================
  Files         283      283              
  Lines       60507    60510       +3     
  Branches     7539     7541       +2     
==========================================
- Hits        54275    54269       -6     
- Misses       4076     4079       +3     
- Partials     2156     2162       +6     

@eaydingol eaydingol marked this pull request as draft July 30, 2024 09:02
@eaydingol eaydingol changed the title Check if the limit is ull Check if the limit is null Jul 30, 2024
@eaydingol eaydingol marked this pull request as ready for review July 30, 2024 09:46
@eaydingol
Copy link
Contributor Author

eaydingol commented Jul 30, 2024

All of the flaky test checks are failing for the tests that require base schedule. The minimal schedule is used in flakyness. The failed tests use "lineitem" table from "multi_create_table.sql".

@eaydingol eaydingol requested a review from hanefi July 31, 2024 08:00
@eaydingol eaydingol merged commit 9e1852e into main Jul 31, 2024
121 of 153 checks passed
@eaydingol eaydingol deleted the fix7663 branch July 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

limit null is implementation is broken when offset is used
2 participants