-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drops PG14 support #7753
Open
naisila
wants to merge
10
commits into
release-13.0
Choose a base branch
from
naisila/drop_pg14
base: release-13.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Drops PG14 support #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naisila
force-pushed
the
naisila/drop_pg14
branch
from
November 19, 2024 10:22
7a04b5c
to
b5ffa71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7753 +/- ##
================================================
- Coverage 89.48% 89.44% -0.04%
================================================
Files 276 276
Lines 60063 59897 -166
Branches 7524 7510 -14
================================================
- Hits 53747 53576 -171
- Misses 4166 4176 +10
+ Partials 2150 2145 -5 |
naisila
force-pushed
the
naisila/drop_pg14
branch
2 times, most recently
from
November 19, 2024 13:50
98ab8c9
to
0a49a3a
Compare
Code & test output changes look good to me. Will do another pass once the branch is rebased & polished and the conflicts are resolved. |
- Remove "$version_num" != 'xx' from configure file - delete all PG_VERSION_NUM = PG_VERSION_XX references in the code - Look at pg_version_compat.h file, remove all _compat functions etc defined specifically for PGXX differences - delete all PG_VERSION_NUM >= PG_VERSION_(XX+1), PG_VERSION_NUM < PG_VERSION_(XX+1) ifs in the codebase - delete ruleutils_xx.c file
naisila
force-pushed
the
naisila/drop_pg14
branch
from
January 24, 2025 11:28
0a49a3a
to
6b109e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Drops PG14 support