Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops PG14 support #7753

Open
wants to merge 10 commits into
base: release-13.0
Choose a base branch
from
Open

Drops PG14 support #7753

wants to merge 10 commits into from

Conversation

naisila
Copy link
Member

@naisila naisila commented Nov 19, 2024

DESCRIPTION: Drops PG14 support

  1. Remove "$version_num" != 'xx' from configure file
  2. delete all PG_VERSION_NUM = PG_VERSION_XX references in the code
  3. Look at pg_version_compat.h file, remove all _compat functions etc defined specifically for PGXX differences
  4. delete all PG_VERSION_NUM >= PG_VERSION_(XX+1), PG_VERSION_NUM < PG_VERSION_(XX+1) ifs in the codebase
  5. delete ruleutils_xx.c file
  6. cleanup normalize.sed file from pg14 specific lines
  7. delete all alternative output files for that particular PG version, server_version_ge variable helps here

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (c55bc8c) to head (9b510e6).
Report is 6 commits behind head on release-13.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-13.0    #7753      +/-   ##
================================================
- Coverage         89.48%   89.44%   -0.04%     
================================================
  Files               276      276              
  Lines             60063    59897     -166     
  Branches           7524     7510      -14     
================================================
- Hits              53747    53576     -171     
- Misses             4166     4176      +10     
+ Partials           2150     2145       -5     

@naisila naisila force-pushed the naisila/drop_pg14 branch 2 times, most recently from 98ab8c9 to 0a49a3a Compare November 19, 2024 13:50
@onurctirtir
Copy link
Member

Code & test output changes look good to me. Will do another pass once the branch is rebased & polished and the conflicts are resolved.

- Remove "$version_num" != 'xx' from configure file

- delete all PG_VERSION_NUM = PG_VERSION_XX references in the code

- Look at pg_version_compat.h file, remove all _compat functions etc defined specifically for PGXX differences

- delete all PG_VERSION_NUM >= PG_VERSION_(XX+1), PG_VERSION_NUM < PG_VERSION_(XX+1) ifs in the codebase

- delete ruleutils_xx.c file
@naisila naisila marked this pull request as ready for review January 24, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants