Merge pull request wal-g#1334 from wal-g/fix-mongo-backup-list

Fix sorting in detailed mongodb backup list
citusdata · Sep 14, 2022 · a72fb73 · a72fb73
2 parents b55404c + 98f1b0d
commit a72fb73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/databases/mongo/backup_list_handler.go b/internal/databases/mongo/backup_list_handler.go
@@ -45,7 +45,7 @@ func HandleDetailedBackupList(folder storage.Folder, output io.Writer, pretty, j
 	}
 
 	sort.Slice(backupDetails, func(i, j int) bool {
-		return backupDetails[i].FinishLocalTime.After(backupDetails[j].FinishLocalTime)
+		return backupDetails[i].FinishLocalTime.Before(backupDetails[j].FinishLocalTime)
 	})
 
 	switch {

diff --git a/internal/databases/mongo/binary/backup.go b/internal/databases/mongo/binary/backup.go
@@ -62,7 +62,9 @@ func (backupService *BackupService) DoBackup(backupName string, permanent bool)
 	defer func() {
 		if err != nil {
 			closeErr := backupCursor.Close(backupService.Context)
-			tracelog.ErrorLogger.Printf("Unable to close backup cursor: %+v", closeErr)
+			if closeErr != nil {
+				tracelog.ErrorLogger.Printf("Unable to close backup cursor: %+v", closeErr)
+			}
 		}
 	}()