Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated SMSCommon.php #31778

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

colemanw
Copy link
Member

Overview

Removes unused file we promised to remove by now.

Before

@deprecated since 5.71 will be removed around 5.77

After

Gone.

Copy link

civibot bot commented Jan 14, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 14, 2025
@demeritcowboy
Copy link
Contributor

Still referenced at

if (CRM_Core_DAO::getFieldValue('CRM_Activity_DAO_Activity', $value, 'subject', 'id') != CRM_Contact_Form_Task_SMSCommon::RECIEVED_SMS_ACTIVITY_SUBJECT) {
$activityCheck++;
}
}
if ($activityCheck == count($this->_activityHolderIds)) {
CRM_Core_Error::statusBounce(ts("The Reply SMS Could only be sent for activities with '%1' subject.",
[1 => CRM_Contact_Form_Task_SMSCommon::RECIEVED_SMS_ACTIVITY_SUBJECT]

@colemanw colemanw marked this pull request as draft January 15, 2025 13:52
@eileenmcnaughton
Copy link
Contributor

@colemanw this #31952 will resolve this PR

@eileenmcnaughton
Copy link
Contributor

Should be OK now with the other merged

@colemanw colemanw marked this pull request as ready for review February 5, 2025 13:51
@colemanw
Copy link
Member Author

colemanw commented Feb 5, 2025

Agree I no longer see any references to it.

@colemanw colemanw merged commit c948452 into civicrm:master Feb 5, 2025
1 check passed
@colemanw colemanw deleted the smsUncommon branch February 5, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants