Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Afform - Improve UX for batch-processing submissions #31906

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Afform - Improve UX for batch-processing submissions #31906

wants to merge 3 commits into from
+32 −89

Conversation

colemanw
Copy link
Member

Overview

Improves the UX and simplifies the code for batch-processing afform submissions

Before

Glitchy UX, see #31884 (comment)

After

Simplified code & solidified UX using standard ApiBatch.

Technical Details

This includes a general improvement to the apiBatch actions: support for a WHERE clause.
Also implemented this for the enable/disable actions: Now only the disabled entities will be enabled & vice versa & ones that already have the correct status will be skipped.

@colemanw
SearchKit - Refactor enable/disable tasks to include WHERE clause logic.
cdf16a5 
WHERE clause ensures prevents redundant updates.
Now only the disabled entities will be enabled & vice versa.
WHERE clauses are merged into task conditions dynamically, improving consistency and reducing redundancy in defining conditions.
@colemanw
SearchKit - Prevent errors after some batch tasks
bec03a7 
New params don't get passed back by every task,
so add the guard first before the rest of the condition.
@civibot civibot
Copy link

civibot bot commented Jan 28, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 28, 2025
This was referenced Jan 28, 2025
Merged
Merged
@colemanw colemanw changed the title Afform actions Afform - Improve UX for batch-processing submissions Jan 29, 2025
@colemanw
Afform - Use apiBatch for process action
db46c20 
Before: Processing form submissions glitchy in the UI

After: Uses standard batch runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colemanw