Attempt (& fail) to use Subscriber interface instead of hook_config

[eileenmcnaughton]

Overview

see #31689

ref https://docs.civicrm.org/dev/en/latest/hooks/usage/symfony/

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

@eileenmcnaughton tests are passing... what's the failure?

[eileenmcnaughton]

@colemanw this is not firing c6d3b95#diff-bd1e75c64b0c3378649766479b064916b8326055ccae2ba05043d4ff3056a1f0R8 & hence the event is not (it falls back to the non-deprecated core function so appears to work but careful use of a debugger...)

[colemanw]

IMO this is not a blocker to the other PR, but FYI other core extensions use AutoService. E.g.

civicrm-core/ext/afform/core/Civi/Afform/Tokens.php

Line 28 in 8d1de54

class Tokens extends AutoService implements EventSubscriberInterface {

[ufundo]

Those developer docs on registering event subscribers are really out of date.

I think:

• it was better when you had the listener class in its own namespace. I think the BAO thing in the docs is outdated/red herring
• to get listened to it needs to also declare itself a service or [im sure theres another way but I cant remember]
• like Coleman says AutoService is your friend, or I think AutoSubscriber exists as a shortcut (service+event subscriber)
• the thing i always forget is scan-classes mixin but you have that
• you have to clear caches for scan-classes to get refreshed

[eileenmcnaughton]

@colemanw @ufundo I tried with the autoservice -it still doesn't fire - I see an error though

#31967

WARNING: Class Civi\LegacyFinder\Finder was expected to have a service definition, but it did not. Perhaps it needs service name.

[colemanw]

@eileenmcnaughton that's good! All you need to do is add @service and @internal annotations to the class (or switch to AutoSubcriber which does that for you)

[eileenmcnaughton]

@colemanw I tried AutoSubscriber in #31967 - but it still didn't fire - I'll put it in though

[eileenmcnaughton]

OK - Autosubscriber worked - although not sure what changed as it seems the cv flush maybe was insufficient to clear enough stuff