Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt-in for controlling what form elements are rendered via civictheme system #1306

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
abbaed0
Add styleguide forms.
richardgaunt Sep 22, 2024
7c9d9e1
Added api for checking whether a form element is supported.
richardgaunt Sep 25, 2024
1cb62f0
Merge branch 'develop' into feature/form-elements-enhancement
joshua-salsadigital Sep 26, 2024
40cb792
Code Update Fixes.
Sep 30, 2024
a220760
Added Fix for Conditional webforms.
Oct 1, 2024
7e50584
@SuppressWarnings(PHPMD.StaticAccess)
Oct 1, 2024
d3e9105
Merge branch 'develop' into feature/form-elements-enhancement
richardgaunt Oct 1, 2024
a4dc623
Merge branch 'develop' into feature/form-elements-enhancement
joshua-salsadigital Oct 3, 2024
84a00e8
Code updates.
Oct 3, 2024
c3b6db0
Code updates.
Oct 3, 2024
f6126b1
Merge branch 'develop' into feature/form-elements-enhancement
joshua-salsadigital Oct 4, 2024
9e73ed4
Form Updates.
Oct 4, 2024
d449c87
Merge branch 'develop' into feature/form-elements-enhancement
richardgaunt Oct 7, 2024
b3a923e
Merge branch 'develop' into feature/form-elements-enhancement
richardgaunt Oct 7, 2024
716c86d
Merge branch 'develop' into feature/form-elements-enhancement
richardgaunt Oct 22, 2024
5864059
Merge branch 'develop' into feature/form-elements-enhancement
richardgaunt Oct 22, 2024
0d2e5ac
Fixed the markup form elements function.
richardgaunt Oct 23, 2024
c0ff030
Added further support for markup elements rendered in fields.
richardgaunt Oct 24, 2024
92b229a
Added fix to support Form element prefix & suffix.
Oct 24, 2024
1b9a5e3
Updated supported fields.
richardgaunt Oct 24, 2024
43c3013
Add container with spacing to civictheme templates.
richardgaunt Oct 25, 2024
13a4734
Merge branch 'develop' into feature/form-elements-enhancement
joshua-salsadigital Oct 25, 2024
4fa5ee9
Revert container change.
richardgaunt Oct 25, 2024
3614da7
Add container template and theme suggestion for webforms.
richardgaunt Oct 25, 2024
f6d484f
Use theme constants.
richardgaunt Oct 29, 2024
b552a24
Added opt-in form property for rendering an element using civictheme.
richardgaunt Oct 30, 2024
27cee88
Update webform to remove some elements we do not use.
richardgaunt Oct 30, 2024
9d1caf4
Further tweaks to webform.
richardgaunt Oct 30, 2024
cb97c4a
Merge branch 'develop' into feature/form-elements-enhancement
richardgaunt Nov 7, 2024
49748bb
Added behat test for Test a sample of the core form elements
Nov 7, 2024
a02a15a
Fixed PHPDoc tag @param references unknown parameter: $form_element_t…
Nov 7, 2024
855e30d
Fixed lint issues.
Nov 7, 2024
6bc1735
Updated test for webforms.
Nov 7, 2024
5a8cd9b
@SuppressWarnings(PHPMD.StaticAccess)StaticAccess Avoid using static…
Nov 7, 2024
54c75da
Update uikit to #main.
Nov 7, 2024
eb362a2
Merge branch 'develop' into feature/form-elements-enhancement
richardgaunt Nov 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
383 changes: 383 additions & 0 deletions tests/behat/features/form_elements.core_form_elements.feature

Large diffs are not rendered by default.

265 changes: 265 additions & 0 deletions tests/behat/features/form_elements.webform_form_elements.feature

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions web/modules/custom/civictheme_dev/civictheme_dev.module
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ function civictheme_dev_preprocess_html(array &$variables): void {
* Implements hook_styleguide_alter().
*/
function civictheme_dev_styleguide_alter(array &$items): void {
// Remove password_confirm field from the form as CivicTheme does not support
// it.
unset($items['form']['content']['password_confirm']);

_civictheme_dev_styleguide__form_test__textfield($items);
_civictheme_dev_styleguide__form_test__textarea($items);
_civictheme_dev_styleguide__form_test__select($items);
Expand Down
14 changes: 14 additions & 0 deletions web/modules/custom/civictheme_dev/civictheme_dev.routing.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
civictheme_dev.styleguide_form:
path: '/civictheme-core-form-elements'
defaults:
_form: 'Drupal\civictheme_dev\Form\CoreFormElementsForm'
_title: 'CivicTheme Core Form Elements Form'
requirements:
_permission: 'access content'
civictheme_dev.admin_styleguide_form:
path: '/admin/structure/civictheme-core-form-elements'
defaults:
_form: 'Drupal\civictheme_dev\Form\CoreFormElementsForm'
_title: 'Core Form Elements Form (Admin Theme)'
requirements:
_permission: 'view the administration theme'
Loading
Loading