-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce external snapshotter and snapshot controller for VolumeSnapshot support #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
changed the title
[WIP] Introduce external snapshotter and snapshot controller
Introduce external snapshotter and snapshot controller
Dec 2, 2024
hlts2
changed the title
Introduce external snapshotter and snapshot controller
Introduced external snapshotter and snapshot controller for VolumeSnapshot support
Dec 2, 2024
hlts2
requested review from
Praveen005,
chadmcrowell,
RealHarshThakur and
DMajrekar
December 2, 2024 05:43
hlts2
changed the title
Introduced external snapshotter and snapshot controller for VolumeSnapshot support
Introduce external snapshotter and snapshot controller for VolumeSnapshot support
Dec 2, 2024
RealHarshThakur
approved these changes
Dec 3, 2024
Signed-off-by: hlts2 <[email protected]>
@RealHarshThakur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
I have added k8s manifest for VolumeSnapshot support.
This PR contains the following components.
WHY
We have plan to support VolumeSnapshot in the civo-csi driver.
Apart from the implementation of csi driver handler, the k8s manifest also needs to be added, so it will be added in this PR.
The
csi-snapshotter
is in error, but this error will be fixed after driver implementation(Create, Delete, List handler) is complete.The following is an error message
I will add an example manifest after all the implementation is complete.