Merge pull request #30 from omus/cv/eq-fix

Fix equality for infinities of different types
cjdoris · Aug 12, 2020 · c8cf5e1 · c8cf5e1
2 parents 5b5decc + 68b0f21
commit c8cf5e1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/src/infinite/comparison.jl b/src/infinite/comparison.jl
@@ -5,6 +5,8 @@ Base.isinf(x::Infinite) = true
 Base.iszero(::Infinite) = false
 
 Base.:(==)(x::Infinite, y::Infinite) = x.signbit == y.signbit
+Base.:(==)(x::Infinite, y::Real) = isinf(y) && signbit(x) == signbit(y)
+Base.:(==)(x::Real, y::Infinite) = y == x
 
 Base.hash(x::Infinite, h::UInt) = hash(isposinf(x) ? Inf : -Inf, h)
 

diff --git a/test/infextendedreal.jl b/test/infextendedreal.jl
@@ -128,6 +128,7 @@
         @test InfExtendedReal(5) == 5
         @test InfExtendedReal(7) == 7.0
         @test InfExtendedReal(4) != InfExtendedReal(1)
+        @test InfExtendedReal(Inf) == InfExtendedReal(∞)
 
         @test hash(InfExtendedReal(3)) == hash(3)
 

diff --git a/test/infinite.jl b/test/infinite.jl
@@ -63,7 +63,11 @@
         @test !iszero(x)
         @test !iszero(-x)
         @test x == x
+        @test x == Inf
+        @test Inf == x
         @test x != -x
+        @test x != -Inf
+        @test Inf != -x
         @test hash(x) != hash(-x)
         @test -x < x
         @test x > -x