Correct Regex for Parsing Workspace.bzl #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected Regex
Removed fail catch for the final two cp commands. On my setup sometimes the script is ran multiple times as part of a build process. I would get errors copying if the src/dest were the same file even though all other operations were successful. Since I'm using this repo in my projects I decided to remove the fail catch on the copy to keep the exit status as 0. Plus if the files are the same the cp failing really isn't an error.
|
@cjweeks Ping. The setup process doesn't work without this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values the regex is searching for have changed and the scripts no longer work. I have edited the regex to work with the current releases of tensorflow.