-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argument to Inlude Group/Org Users in Dump and Load (+ fixed tests) #208
Argument to Inlude Group/Org Users in Dump and Load (+ fixed tests) #208
Conversation
- Added `--include-users` argument for group and org dump/load.
- Changed ubuntu image from `20.04` to `latest`.
- Removed unsupported python version from `actions/setup-python@v4`.
- Added extra condition to catch possible key errors. - Changed `python2` to just `python` in test class.
- Added new `include-users` arg to dump and load tests.
- Closed files from possible memory leaking.
Working on fixing the tests currently. Python 2.7 support has been removed fully from |
- Fixed issues with `test_upload` mock action for tests.
- Attempting to use python images as python 2 has been removed from the `actions/setup-python`.
- Attempting to use python images.
Okay I also fixed the tests. Sadly python 2 is no longer supported in There was also a reported possible memory leak when running the tests due to unclosed files from the dump and search subcommands when not using |
IIUC |
@wardi Yeah, so it would really only be a thing for https://github.com/ckan/ckanapi/blob/master/ckanapi/cli/load.py#L267
There is code which copies over the users in the above function. So if the users are not available, it will use the ones from the |
- Removed include users from dump subcommand and tests.
Co-authored-by: Ian Ward <[email protected]>
feat(cli): added include-users option for group and org dump/load;
--include-users
argument for group and org dump/load.