t/44: Allowed a configuration to CKEditorInspector#attach() to attach the i… #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nspector collapsed. Implemented CKEditorInspector#destroy().
|
We may want to postpone the merge and introduce #48 in this PR. |
ma2ciek
reviewed
Jun 17, 2019
ma2ciek
reviewed
Jun 18, 2019
…Enhanced the deprecated syntax warning.
ma2ciek
reviewed
Jul 4, 2019
|
@ma2ciek Can you review it again? |
|
Sure, I'll review it. |
|
I'm bumping deps and aligning to the latest API. |
|
Looks like it's ready. |
ma2ciek
reviewed
Sep 20, 2019
ma2ciek
reviewed
Sep 20, 2019
ma2ciek
reviewed
Sep 20, 2019
ma2ciek
reviewed
Sep 20, 2019
ma2ciek
reviewed
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Allowed attaching the inspector collapsed using a configuration passed to
CKEditorInspector#attach(). Implemented theCKEditorInspector#destroy()method. UnifiedCKEditorInspector#attach()arguments syntax and allowed attaching to multiple instances at a time. Closes #44. Closes #42. Closes #48.BREAKING CHANGE: The
CKEditorInspector.attach( 'editor-name', editor );syntax was deprecated and replaced by an object literalCKEditorInspector.attach( { 'editor-name': editor, ... } );.