Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted the package to ESM #196

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Converted the package to ESM #196

merged 8 commits into from
Oct 30, 2024

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Oct 3, 2024

Suggested merge commit message (convention)

Other: Converted the project repository to ESM. Closes #192.


Additional information

For now, the ckeditor5 is locked on the latest nightly version in this PR, because latest stable version is not compatible with changes with ckeditor5-dev-*. Before merging this PR, we should switch back to the latest tag.

Restored ckeditor5 back on latest tag in 24f77cc.

@psmyrek psmyrek marked this pull request as ready for review October 29, 2024 14:34
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 30f0ada into master Oct 30, 2024
14 checks passed
@pomek pomek deleted the ci/3772 branch October 30, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert the repository to ESM and use the latest ckeditor5-dev-*
2 participants