Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dll:build script not working on Windows #17406

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

przemyslaw-zan
Copy link
Member

Suggested merge commit message (convention)

Internal: Fixed dll:build script not working on Windows. Closes #17401.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@przemyslaw-zan przemyslaw-zan changed the title Normalized path in check. Fixed dll:build script not working on Windows Nov 6, 2024
@przemyslaw-zan przemyslaw-zan changed the title Fixed dll:build script not working on Windows Fixed dll:build script not working on Windows Nov 6, 2024
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@przemyslaw-zan przemyslaw-zan merged commit f983c1b into master Nov 6, 2024
10 checks passed
@przemyslaw-zan przemyslaw-zan deleted the ck/17401 branch November 6, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn run dll:build script throws on Windows
2 participants