Checking out to specific commit (hash) works as it should. #35
Conversation
| @@ -55,19 +55,28 @@ module.exports = { | |||
| if ( stdout ) { | |||
| throw new Error( `Package "${ data.packageName }" has uncommitted changes. Aborted.` ); | |||
| } | |||
| } ) | |||
| .then( () => { | |||
|
|
|||
There was a problem hiding this comment.
I don't like merging these callbacks. The log handling is a separate task which, btw, should be done differently (related to #13, but not exactly this).
Reinmar
changed the title
|
First of all, there's an important bug that errors aren't passed correctly to the logger:
I fixed one issue like that yesterday, but here's another. |
|
I'll work on this. |
|
OK, turns out that the logging mechanism is broken. The issue is that the exec command logs the error and rejects the promise with a logger instance. That logger instance is then passed to the update command which don't expect it. So, this issue must be solved in #13. The caller must not need to care about logs and rejected promise should always be rejected with an error, not some custom object. |
Fixes: #34.