Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solver cond val #157

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix solver cond val #157

wants to merge 4 commits into from

Conversation

saraseidl
Copy link
Collaborator

Path Selection
Fixes essential input selection

Value Selection
Consider more values in inverse and consistent value computation

Propagation
Update assignment for inputs only

Details in the comments.

@saraseidl saraseidl requested a review from mstarzinger August 11, 2021 08:52
Copy link
Collaborator

@mstarzinger mstarzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good. I left a couple of suggestions. You found quite a few interesting bugs here. Nice work! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants