feat: Simple support to complete external subcommand #5706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannmu
force-pushed
the
external_subcommand
branch
from
747dd4c
to
ddcb343
Compare
epage
reviewed
Aug 29, 2024
| #[test] | ||
| fn suggest_external_subcommand() { | ||
| let mut cmd = Command::new("dynamic") | ||
| .arg(clap::Arg::new("positional").value_parser(["pos1", "pos2", "pos3"])); |
There was a problem hiding this comment.
This is not a subcommand and adding subcommand candidates when no subcommands are taken is strange. I wonder if we should gate the reading of SubcommandCandidates based on whether external subcommands are allowed.
epage
reviewed
Aug 29, 2024
| #[cfg(feature = "unstable-ext")] | ||
| #[allow(clippy::should_implement_trait)] | ||
| pub fn add<T: CommandExt + crate::builder::ext::Extension>(mut self, tagged: T) -> Self { | ||
| self.app_ext.set(tagged); |
There was a problem hiding this comment.
app_ext is different than a command_ext and we need to carefully consider this.
A Command can either be a top-level / application command or a subcommand. Command builder methods deal with one, the other, or both. app_ext was created for dealing with top-level / application-related data.
Even if we add a new ext field, we'd need to decide how to name the methods related to it.
|
#5766 will unblock this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simply add support for external subcommand completions. It does not provide any support for forward completions regarding issue #5653.