-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data ES-CT #269
Data ES-CT #269
Conversation
@marilinapisani, thanks for the pull request. If you need any explanation of errors in the output: https://github.com/clarin-eric/ParlaMint/runs/7127336080?check_suite_focus=true#step:4:27 |
@matyaskopp, thanks for your comment. For the next pull, where am I supposed to change the target branch? I followed the instructions in the Contributing file. Sorry if this is a basic question, this is my first commit. Regarding the error logs, I am reviewing them and so far they seem clear to me. |
yes, the target branch has to be data. |
perfect! |
@matyaskopp I do have doubts regarding this error message: "New document or paragraph starts when the last token of the previous sentence says SpaceAfter=No." Could you kindly clarify it for me? Thanks! |
This error is reported by this tool https://github.com/UniversalDependencies/tools/blob/master/validate.py. It uses the wrong id in the report: https://github.com/clarin-eric/ParlaMint/runs/7127336080?check_suite_focus=true#step:4:189
the issue is in the following sentence ( <pc ana="mte:PUNCT" join="right" msd="UPosTag=PUNCT" xml:id="ParlaMint-ES-CT_2015-11-09.u.1.4.2.92">.</pc>
<linkGrp targFunc="head argument" type="UD-SYN"> ... </lingGrp>
</s>
</seg> The last token in the sentence( All last paragraph tokens in your data seem to contain |
That's very helpful, thanks! |
Can this pull request be closed (without merging)? |
Added samples to folder