Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v11_1 handler #546

Merged

Conversation

hoank101
Copy link
Contributor

Summary of changes

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@StrathCole
Copy link
Collaborator

@hoank101 do we need the 11_1 because of testnet only? could we then remove v11 on mainnet?

@hoank101
Copy link
Contributor Author

do we need the 11_1 because of testnet only? could we then remove v11 on mainnet?

yeah, I just removed

@StrathCole
Copy link
Collaborator

do we need the 11_1 because of testnet only? could we then remove v11 on mainnet?

yeah, I just removed

The question was if it can be removed or if testnet upgrade prop will fail then. I remember an issue with the tax upgrade I did in a similar situation.

@hoank101
Copy link
Contributor Author

The question was if it can be removed or if testnet upgrade prop will fail then. I remember an issue with the tax upgrade I did in a similar situation.

yeah, I think will remove when upgrade mainnet, or keep it, a litter bit redundant but ok

@StrathCole StrathCole merged commit be07738 into classic-terra:orbitlabs/unforking Jan 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants