Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #689

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Update README.md #689

merged 5 commits into from
Feb 14, 2025

Conversation

zazathomas
Copy link
Contributor

Minor changes to helm deployment instructions

Minor changes to helm deployment instructions
Copy link

netlify bot commented Feb 9, 2025

Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 717db75
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/67ae37c64fad3f0008c98b4a

Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is complaining about missing generates files, can you amend to get this merged, please?

@zazathomas
Copy link
Contributor Author

@prometherion Made the required changes.

@prometherion
Copy link
Member

CI is complaining, may I ask you to run make -C charts/kamaji docs and commit the changes?

@zazathomas
Copy link
Contributor Author

Done @prometherion

@prometherion
Copy link
Member

I'm a bit confused @zazathomas: https://github.com/clastix/kamaji/pull/689/files

It seems we don't have any change: I suspect you edited the wrong file, since README.md is automatically generated from the following template

https://github.com/clastix/kamaji/blob/master/charts/kamaji/README.md.gotmpl

@zazathomas
Copy link
Contributor Author

@prometherion
Oh yeah that's were the mix up came from, I edited the readme directly. I'll fix it now

@zazathomas
Copy link
Contributor Author

@prometherion
I've pushed the changes. Should be good now

@prometherion prometherion merged commit 0c1c253 into clastix:master Feb 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants