Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Regions in 3D #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Regions in 3D #187

wants to merge 2 commits into from

Conversation

cjvogl
Copy link

@cjvogl cjvogl commented Jan 17, 2017

Implementation of regions via flag2refine.

@cjvogl cjvogl mentioned this pull request Jan 17, 2017
Open
9 tasks
@rjleveque
Copy link
Member

Thanks @cjvogl, but I suggest we hold off on this for the 5.4.0 release. In 2d there is a separate flagregions.f90 file, since flag2refine might not be used if the user specifies Richardson error estimation for the flagging, and we probably want to do something consistent.

I think we also need to modify the utilities so that setrun.py can specify regions?

@cjvogl
Copy link
Author

cjvogl commented Jan 17, 2017

Works for me @rjleveque. I believe all the changes to the utilities were taken care of in #169 (just making a note of this so I can remember down the road).

@rjleveque
Copy link
Member

Thanks for the reminder! Let's work more on this soon, along with the slices output and other 3d enhancements.

@cjvogl cjvogl changed the title Regions in 3D [WIP] Regions in 3D Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjvogl @rjleveque