Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors #183

Merged
merged 3 commits into from
May 10, 2018
Merged

Fix errors #183

merged 3 commits into from
May 10, 2018

Conversation

ketch
Copy link
Member

@ketch ketch commented May 10, 2018

This removes some broken links and makes a few things compatible with Python 3.

ketch added 3 commits May 10, 2018 12:36
Also remove plot_directive extension since it is now
part of matplotlib (and the version kept here wasn't Python 3-compatible).
And fix one more instance where we needed to prepend clawpack before pyclaw.
@ketch
Copy link
Member Author

ketch commented May 10, 2018

Also fixes #153 (though I have no idea if this is exactly the intended photo).

@rjleveque
Copy link
Member

Yes, that's the photo I had added but forgot to commit and push.

@rjleveque rjleveque merged commit 34db9dc into clawpack:master May 10, 2018
@rjleveque
Copy link
Member

@ketch: This didn't fix some problems due to docstring formatting in pyclaw routines, e.g. in pyclaw/solvers.html:

System Message: ERROR/3 
(/Users/rjl/git/clawpack/clawpack/pyclaw/sharpclaw/solver.py:docstring 
of clawpack.pyclaw.sharpclaw.solver.SharpClawSolver, line 29)

Unexpected indentation.

I didn't see a pyclaw PR for this.

@ketch
Copy link
Member Author

ketch commented May 16, 2018

I think all the remaining Sphinx errors are fixed in the 2 PRs I just submitted (pyclaw and riemann).

@ketch ketch deleted the fix_errors branch May 16, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants