Polynomial reconstruction in SharpClaw #492
Conversation
|
Just a reminder for anybody testing this -- you'll need to rebuild: |
| @@ -9,7 +9,7 @@ module ClawParams | |||
| integer :: num_dim, num_waves, index_capa | |||
|
|
|||
| ! Method-related parameters: | |||
| integer :: char_decomp, lim_type, weno_order | |||
| integer :: char_decomp, lim_type, reconstruction_order | |||
There was a problem hiding this comment.
Just a note: renaming weno_order to reconstruction_order is backward-incompatible, but it is a small enough change that I think it's okay for this to go into 5.3.
There was a problem hiding this comment.
@ketch, if needed for 5.4 I can add backward-compatibility...
There was a problem hiding this comment.
Maybe that's a good idea; we can just emit a warning saying that the old attribute will be deprecated in future versions.
|
I just merged in the fix for the doctests (from master) so this is passing now. |
|
|
||
| Order of the WENO reconstruction. From 1st to 17th order (PyWENO) | ||
| Order of the reconstruction. From 1st to 17th order (PyWENO), and from | ||
| 4 to 10 (even) in Poly |
There was a problem hiding this comment.
This should say
From 5th to 17th order (odd) for WENO reconstruction and from 4th to 10th order (even) for piecewise polynomial reconstruction.
There was a problem hiding this comment.
Ah, I just noticed that it's wrong in master...
|
This looks great and will be very useful. It would of course be nice to have:
|
|
@ketch working on
|
|
What's the status of this PR? |
|
I made some modifications to it in my fork and rebased it... I haven't got On Saturday, October 24, 2015, Kyle Mandli [email protected] wrote:
Damián ubi dubium ibi libertas |
|
Thanks for the update. Would you like this included in the 5.3.1 release or would this be better for the 5.4.0 release? |
|
If @sanromd can add a test or two soon, it would be great to get this into 5.4.0. It probably shouldn't go into 5.3.1 since it's a major feature and 5.4 is coming very soon anyway. |
|
Changes Unknown when pulling 458933d on sanromd:dev-poly into * on clawpack:master*. |
…order for Poly is >6
…ruction can be selected using lim_type=3
…ruction_orders included'
This PR adds a routine for polynomial based reconstruction in SharpClaw. In detail,