Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added minimal configuration for code scanning #319

Merged
merged 11 commits into from
Dec 17, 2020
Merged

Added minimal configuration for code scanning #319

merged 11 commits into from
Dec 17, 2020

Conversation

AntoineRondelet
Copy link
Contributor

@AntoineRondelet AntoineRondelet commented Nov 24, 2020 •
edited
Loading

See: #304

@AntoineRondelet AntoineRondelet removed the request for review from dtebbs November 27, 2020 14:55
@AntoineRondelet AntoineRondelet changed the title [WIP] Added minimal configuration for cpp code scanning Added minimal configuration for code scanning Nov 27, 2020
@AntoineRondelet
Copy link
Contributor Author

Related to: github/docs#1637

@AntoineRondelet
Copy link
Contributor Author

AntoineRondelet commented Dec 1, 2020 •
edited
Loading

Seems like the CI is not triggered (probably because of https://www.githubstatus.com/incidents/sxthxvdlljk4). When Github Action is repaired, let's see if the macOS build is faster than the last CI run (#319 (comment)). This will educate when we enable code scanning (#319 (comment)).
Moving this PR back to WIP for now.

@AntoineRondelet AntoineRondelet changed the title Added minimal configuration for code scanning [WIP] Added minimal configuration for code scanning Dec 1, 2020
@AntoineRondelet AntoineRondelet changed the title [WIP] Added minimal configuration for code scanning Added minimal configuration for code scanning Dec 16, 2020
dtebbs
dtebbs approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@dtebbs dtebbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntoineRondelet AntoineRondelet merged commit ccfbdfa into develop Dec 17, 2020
@AntoineRondelet AntoineRondelet deleted the code-scanning-ci branch December 21, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtebbs dtebbs dtebbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoineRondelet @dtebbs