Improvement for the Sound played #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added bell sound on opening. Changed from Chrome to Edge Chromium Added datetime to "Opened"-info
Fixed error index out of range
Relying on the order of the url parameters is not a good idea and will likely break again in the future
…ement Fixes #7 - Use urlparse to build the amazon url
… the script will stop monitoring for new links if one is open in browser
Config through .yml files, fixed open new links if one is already open.
Wrong Parameters in Amazon URL. See https://discord.com/channels/768363408109469697/851742645218967582/851742901632892950 for more details.
PartAlert links are not containing amazon URL information anymore (see issue #13 ). Removed condition to construct Amazon link. PartAlert link will now be opened instead of Amazon link.
Removed part that the Amazon URL will be contstucted, as the partalert URL is not containing Amazon informations anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firrstly I really appreciate your project here and Im very thankfull that you posted it.
Secondly I would do some changes with the Sound, becouse right now you here it when you close the site but it would be better if you here it when the website gets opened. For that you just need to put it aboth the if "partalert.net" in
url: and under the if any(x in url.lower() for x in keywords) and all(x not in url.lower() for x in blacklist): as shown in my Professional drawing. XD
Another thing is that the bot is stoping the programm after you close the website so it is just capable of opening one site at once i really dont know how to fix it in phyton never programmed with that programm mayby you know how to do it I just wanted to mention it becouse I noticed it a second ago.
Lg