Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Missing "Album artist-album" French translation #203

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remjg
Copy link

@remjg remjg commented Feb 26, 2020

In French, on of the pref_library_grouping_values translation is missing, the one for albumartist-album.

Hence, the options don't correspond to the correct grouping features of the library, and the last option is also missing.

Looking at the /app/src/main/res/values/array.xml file, there should be 7 options in the following order :

<string-array name="pref_library_grouping_values">
        <item>artist</item>
        <item>artist-album</item>
        <item>albumartist-album</item>
        <item>artist-year</item>
        <item>album</item>
        <item>genre-album</item>
        <item>genre-artist-album</item>
</string-array>

I think that this problem is present in others languages too where I can only see 6 options. Not sure my pull request answer the issue completely, I have never looked into how translations work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant